lkml.org 
[lkml]   [2018]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 4/4] remoteproc: qcom: q6v5-pil: Add PDC restart for modem on SDM845 SoCs
    From
    Date
    On Fri, 2018-07-27 at 20:58 +0530, Sibi Sankar wrote:
    > In the presence of a PDC block working with subsystem RSC,
    > assert/deassert PDC restart in modem start/stop path.
    >
    > Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
    > ---
    > .../bindings/remoteproc/qcom,q6v5.txt | 4 +++
    > drivers/remoteproc/qcom_q6v5_pil.c | 27 ++++++++++++++++---
    > 2 files changed, 27 insertions(+), 4 deletions(-)
    >
    > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
    > index 601dd9f389aa..124fb1dc6fb8 100644
    > --- a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
    > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
    [...]
    > @@ -1182,6 +1192,15 @@ static int q6v5_init_reset(struct q6v5 *qproc)
    > return PTR_ERR(qproc->mss_restart);
    > }
    >
    > + if (qproc->has_alt_reset) {
    > + qproc->pdc_restart = devm_reset_control_get(qproc->dev,
    > + "pdc_restart");

    Please use devm_reset_control_get_exclusive() instead.

    > + if (IS_ERR(qproc->pdc_restart)) {
    > + dev_err(qproc->dev, "failed to acquire pdc restart\n");
    > + return PTR_ERR(qproc->pdc_restart);
    > + }
    > + }
    > +
    > return 0;
    > }

    regards
    Philipp

    \
     
     \ /
      Last update: 2018-07-31 10:54    [W:4.084 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site