Messages in this thread |  | | Date | Mon, 30 Jul 2018 05:10:30 +0200 | From | Andrea Parri <> | Subject | [Question] bluetooth/{bnep,cmtp,hidp}: memory barriers |
| |
Hi,
I'm currently puzzled by the the three calls to smp_mb__before_atomic() in bnep_session(), cmtp_session() and hidp_session_run() respectively:
On the one hand, these barriers provide no guarantee on the subsequent atomic_read(s->terminate) (as the comments preceding the barriers seem to suggest), because atomic_read() is not a read-modify-write.
On the other hand, I'm currently unable to say *why such an "mb" would be required: not being too familiar with this code, I figured I should ask before sending a patch. ;-)
Andrea
|  |