Messages in this thread | | | Date | Tue, 3 Jul 2018 09:10:55 +0100 (BST) | From | Justin Skists <> | Subject | Re: [PATCH 3/3] drivers/speakup: Fix style and coding warnings |
| |
> On 03 July 2018 at 08:31 Tamir Suliman <tsuliman@linuxvaults.com> wrote:
> +++ b/drivers/staging/speakup/keyhelp.c > @@ -167,7 +167,7 @@ int spk_handle_help(struct vc_data *vc, u_char type, u_char ch, u_short key) > synth_printf("%s\n", spk_msg_get(MSG_HELP_INFO)); > build_key_data(); /* rebuild each time in case new mapping */ > return 1; > - } else { > + } else if {
Interesting construct...
> @@ -787,7 +787,7 @@ static ssize_t message_store_helper(const char *buf, size_t count, > continue; > } > > - index = simple_strtoul(cp, &temp, 10); > + index = simple_ktrtoul(cp, &temp, 10);
Did you compile this?
Justin.
| |