lkml.org 
[lkml]   [2018]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v7 1/4] mfd: bd71837: mfd driver for ROHM BD71837 PMIC
    Hi,
    Missatge de Lee Jones <lee.jones@linaro.org> del dia dt., 3 de jul.
    2018 a les 8:56:
    >
    > On Tue, 26 Jun 2018, Enric Balletbo Serra wrote:
    >
    > > Hi Matti,
    > >
    > > Missatge de Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> del
    > > dia dt., 26 de juny 2018 a les 14:03:
    > > >
    > > > Hello Again Eric,
    > > >
    > > > On Tue, Jun 26, 2018 at 01:40:40PM +0200, Enric Balletbo Serra wrote:
    > > > > Hi Matti,
    > > > > Missatge de Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> del
    > > > > dia dt., 26 de juny 2018 a les 13:25:
    > > > > > On Tue, Jun 26, 2018 at 11:06:33AM +0200, Enric Balletbo Serra wrote:
    > > > > > > Missatge de Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> del
    > > > > > > dia dt., 19 de juny 2018 a les 12:57:
    > > > > >
    > > > > > > > +static const struct of_device_id bd71837_of_match[] = {
    > > > > > > > + { .compatible = "rohm,bd71837", .data = (void *)0},
    > > > > > > > + { },
    > > > > > >
    > > > > > > nit: { /* sentinel */ }
    > > > > >
    > > > > > I am sorry but I didn't quite get the point here. Could you please
    > > > > > explain what did you expect to be added here?
    > > > > >
    > > > >
    > > > > It's a nit but It is a good practice to specify that the last entry is
    > > > > a sentinel. Just this.
    > > > >
    > > > > +static const struct of_device_id bd71837_of_match[] = {
    > > > > + { .compatible = "rohm,bd71837", .data = (void *)0},
    > > > > + { /* sentinel */ }
    > > > > +};
    > > >
    > > > Oh, I see. Finally something I can disagree =) I quickly opened few
    > > > random drivers which declare match table. None of them practiced this
    > > > good practice. So I guess it is not such a standard after all. And I
    > > > guess the meaning of last entry in match table should be quite obvious.
    > > > Adding the comment /* sentinel */ sounds like stating the obvious at
    > > > best - at worst it gets one just to wonder what the "sentinel" means =)
    > > >
    > >
    > > git grep "/\* sentinel \*/"
    > >
    > > Anyway, I marked this change as a nit, so you don't need to change. I
    > > just commented because at some point I received a "complain" when I
    > > didn't add it. But this is up to the maintainer and I am not sure if
    > > the "complain" was received in this subsystem :)
    >
    > Certainly not from me. I don't agree with the practice.
    >
    Ok, Removed from my notes.

    > I'd like to know who is enforcing this!

    I tried to find from where my note comes from but I did not find it.
    Anyway, it's clear now that you don't like it, so I'll remove from the
    pending patches I have and see if someone complains about it again.

    Thanks,
    Enric

    >
    > --
    > Lee Jones [李琼斯]
    > Linaro Services Technical Lead
    > Linaro.org │ Open source software for ARM SoCs
    > Follow Linaro: Facebook | Twitter | Blog

    \
     
     \ /
      Last update: 2018-07-03 10:11    [W:2.663 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site