Messages in this thread | | | Date | Tue, 3 Jul 2018 15:48:43 -0600 | From | Rob Herring <> | Subject | Re: [PATCH v2 1/4] iio: hx711: add data-ready-delay-ns property in DT |
| |
On Sat, Jun 30, 2018 at 06:32:32PM +0100, Jonathan Cameron wrote: > On Mon, 25 Jun 2018 17:18:02 +0200 > Andreas Klinger <ak@it-klinger.de> wrote: > > > add data-ready-delay-ns property for hx711 ADC > > this is the delay after rising PD_SCK until DOUT is read and assumed to be > > ready > > > > Signed-off-by: Andreas Klinger <ak@it-klinger.de> > > Hmm. It's not particularly generic... I think this should have > have vendor prefix until we have some visibility of whether it > is a common thing we want to standardise around or not.
Agreed. Doesn't look like any interface I've seen before.
Since it's bit-banging, seems to me it would be better to specify the frequency for PD_SCK and sample DOUT just before or after setting PD_SCK low.
Rob
> I'll also be waiting for a devicetree ack on this one as it's a > tiny bit unusual. > > Thanks, > > Jonathan
| |