Messages in this thread | | | Date | Sun, 29 Jul 2018 10:46:04 +0100 | From | John Whitmore <> | Subject | Re: [PATCH 01/10] staging:rtl8192u: Remove typedef of struct cmpk_txfb_t - Style |
| |
On Sun, Jul 29, 2018 at 10:10:55AM +0200, Greg KH wrote: > On Wed, Jul 25, 2018 at 11:16:21PM +0100, John Whitmore wrote: > > -typedef struct tag_cmd_pkt_tx_feedback { > > +struct cmpk_txfb_t { > > /* DWORD 0 */ > > u8 element_id; /* Command packet type. */ > > u8 length; /* Command packet length. */ > > @@ -53,7 +53,7 @@ typedef struct tag_cmd_pkt_tx_feedback { > > /* DWORD 5 */ > > u16 reserve3; > > u16 duration; > > -} cmpk_txfb_t; > > +}; > > People use the "_t" to try to denote a "typedef". When converting to > just a structure, there is no need to keep the _t anymore at all, so > this should just be "struct cmpk_txfb". > > Or just drop the typedef and use the name for the struct they had here > already, "struct tag_cmd_pkt_tx_feedback", that also would work. > > Same for all of the other patches in this series. > > thanks, > > greg k-h
Oops again. Sorry, that should have occured to me. I'll fix up the affected and resend.
thank you
jwhitmore
| |