Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Sun, 29 Jul 2018 11:00:15 +0200 | Subject | Re: [PATCH] m68k/mac: Rework patch "use time64_t in RTC handling" |
| |
Hi Finn, Arnd,
On Tue, Jul 24, 2018 at 9:07 AM Finn Thain <fthain@telegraphics.com.au> wrote: > This addresses the issues arising from commit 324caa29cd04 > ("m68k: mac: use time64_t in RTC handling"). > > Adopt __u32 for the union in via_read_time(), consistent with changes > to via_write_time(). > > Use low_32_bits() in via_write_time(), consistent with changes to
lower_32_bits()
> pmu_write_time() and cuda_write_time(). > > Have via_read_time() return a time64_t, consistent with changes to > pmu_read_time and cuda_read_time().
pmu_read_time()
> Drop the pointless wraparound conditional in via_read_time(). > > Cc: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Thanks!
Applied to master with the above fixed. Folded into the original commit on for-v4.19, with:
[fthain: Adopt __u32 for the union in via_read_time(), consistent with changes to via_write_time()] [fthain: Use lower_32_bits() in via_write_time(), consistent with changes to pmu_write_time() and cuda_write_time()] [fthain: Have via_read_time() return a time64_t, consistent with changes to pmu_read_time() and cuda_read_time()] [fthain: Drop the pointless wraparound conditional in via_read_time()] Signed-off-by: Finn Thain <fthain@telegraphics.com.au> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |