lkml.org 
[lkml]   [2018]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/3] tty: Make constants to be enums instead of #define in goldfish.c
On Tue, Jul 24, 2018 at 05:51:32PM -0700, rkir@google.com wrote:
> From: Roman Kiryanov <rkir@google.com>
>
> enums produce better compilation errors than defines.

Yes, they can, if you use them correctly. Which you are not doing here,
so this patch really does nothing. Why should we take it?

confused,

greg k-h

\
 
 \ /
  Last update: 2018-07-28 16:52    [W:0.079 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site