lkml.org 
[lkml]   [2018]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 03/10] atmel: hide unused procfs helpers
From
Date
On 07/27/2018 02:24 AM, Kalle Valo wrote:
> (fixing top posting)
>
> YueHaibing <yuehaibing@huawei.com> writes:
>
>> On 2018/7/13 14:46, YueHaibing wrote:
>>> When CONFIG_PROC_FS isn't set, gcc warning this:
>>>
>>> drivers/net/wireless/atmel/atmel.c:1402:12: warning: ‘atmel_proc_show’ defined but not used [-Wunused-function]
>>> static int atmel_proc_show(struct seq_file *m, void *v)
>>> ^
>>> fix this by adding #ifdef around it.
>>>
>>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>
>> pls ignore this,my bad.
>
> Why should I drop this? Does the patch have something wrong which I'm
> missing?
>
> I'm asking because I prefer this over Randy's version:
>
> https://patchwork.kernel.org/patch/10512913/

Take it. I don't mind.

--
~Randy

\
 
 \ /
  Last update: 2018-07-27 17:46    [W:0.037 / U:0.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site