lkml.org 
[lkml]   [2018]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] media: stv090x: fix if-else order
On Thu, Jul 26, 2018 at 04:26:07PM -0300, Mauro Carvalho Chehab wrote:
> Em Fri, 1 Jun 2018 19:12:21 +0300
> Ivan Bornyakov <brnkv.i1@gmail.com> escreveu:
>
> > There is this code:
> >
> > if (v >= 0x20) {
> > ...
> > } else if (v < 0x20) {
> > ...
> > } else if (v > 0x30) {
> > /* this branch is impossible */
> > }
> >
> > It would be sensibly for last branch to be on the top.
>
> Have you tested it and check at the datasheets if dev_ver > 0x30 makes
> sense?
>
> If not, I would prefer, instead, to remove the dead code, as this
> patch may cause regressions (adding a FIXME comment about this
> special case).
>

Hi, Mauro!

Actually, I did not test it, because I did not have the hardware.
But, in the other places of the code, the same if cases are used.

Here are a couple examples:

static int stv090x_dvbs_track_crl(struct stv090x_state *state)
{
if (state->internal->dev_ver >= 0x30) {
...
} else {
...
}

...
}

static u32 stv090x_srate_srch_coarse(struct stv090x_state *state)
{
...

if (state->internal->dev_ver >= 0x30) {
...
} else if (state->internal->dev_ver >= 0x20) {
...
}

...
}

\
 
 \ /
  Last update: 2018-07-27 13:11    [W:0.040 / U:0.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site