Messages in this thread | | | From | Baolin Wang <> | Date | Fri, 27 Jul 2018 16:41:15 +0800 | Subject | Re: [PATCH v3 1/2] leds: core: Introduce generic pattern interface |
| |
Hi Pavel,
On 27 July 2018 at 16:36, Pavel Machek <pavel@ucw.cz> wrote: > Hi! > >> > This should be a bit better. I attempted to compile it with your >> > driver, but whether it works is an open question. >> >> Sorry for late reply. I've compiled and tested this version on my >> platform, the hardware pattern can work with one small fix as below. >> >> if (led_cdev->pattern_set && !led_cdev->pattern_set(led_cdev, >> data->steps, data->nsteps)) { >> return; >> } >> >> But I saw there are lots coding style issues and something can be >> improved in this patch, so will you send out one clean patch (I will >> help to test the hardware pattern support)? Or I can help to improve >> this code and try to upstream it again? > > If you could do the upstreaming, that would be great.
OK, I will improve the code and test the software/hardware pattern, and upstream it again with keeping the original authorization.
> I tried to get hardware accelerated LED to work on N900, but that > hardware is rather complex, so it would take me some time...
-- Baolin Wang Best Regards
| |