Messages in this thread | | | From | Srinath Mannam <> | Date | Fri, 27 Jul 2018 14:06:46 +0530 | Subject | Re: [PATCH] serial: 8250_dw: Add ACPI support for uart on Broadcom SoC |
| |
Hi Andy,
Thank you very much for quick review. I will address your comment and send next patch set.
Regards, Srinath.
On Fri, Jul 27, 2018 at 2:04 PM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > On Fri, 2018-07-27 at 09:31 +0530, Srinath Mannam wrote: >> Add ACPI identifier HID for UART DW 8250 on Broadcom SoCs >> to match the HID passed through ACPI tables to enable >> UART controller. >> >> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com> >> Reviewed-by: Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com >> > >> Tested-by: Vladimir Olovyannikov <vladimir.olovyannikov@broadcom.com> >> Reviewed-by: Ray Jui <ray.jui@broadcom.com> > > One comment below, after addressing it, > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > >> --- >> drivers/tty/serial/8250/8250_dw.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/tty/serial/8250/8250_dw.c >> b/drivers/tty/serial/8250/8250_dw.c >> index aff04f1..7ea94ec 100644 >> --- a/drivers/tty/serial/8250/8250_dw.c >> +++ b/drivers/tty/serial/8250/8250_dw.c >> @@ -708,6 +708,7 @@ static const struct acpi_device_id >> dw8250_acpi_match[] = { >> { "AMD0020", 0 }, >> { "AMDI0020", 0 }, >> { "HISI0031", 0 }, >> + { "BRCM2032", 0 }, > > Let's keep this in order (yes, I know about INT* ones above, but that is > not related to this patch right now) > >> { }, >> }; >> MODULE_DEVICE_TABLE(acpi, dw8250_acpi_match); > > -- > Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Intel Finland Oy
| |