lkml.org 
[lkml]   [2018]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RT v3] arm64: fpsimd: use preemp_disable in addition to local_bh_disable()
On 2018-07-27 05:17:23 [+0200], Mike Galbraith wrote:
> On Thu, 2018-07-26 at 17:06 +0200, Sebastian Andrzej Siewior wrote:
> >
> > @@ -1115,6 +1139,7 @@ void kernel_neon_begin(void)
> >
> > BUG_ON(!may_use_simd());
> >
> > + preempt_disable();
> > local_bh_disable();
> >
> > __this_cpu_write(kernel_neon_busy, true);
> > @@ -1131,6 +1156,7 @@ void kernel_neon_begin(void)
> > preempt_disable();
>
> Nit: this preempt_disable() could be removed...
>
> > local_bh_enable();
> > + preempt_enable();
> > }
> > EXPORT_SYMBOL(kernel_neon_begin);
>
> ...instead of adding this one.

It could. I have currently no idea for the long term solution and this
keeps track what is intended to do. It might get replaced with
preempt_.*_rt()…

> -Mike

Sebastian

\
 
 \ /
  Last update: 2018-07-27 09:58    [W:0.084 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site