lkml.org 
[lkml]   [2018]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] sched/numa: do not balance tasks onto isolated cpus
On Thu, Jul 26, 2018 at 04:19:08PM +0800, Cheng Lin wrote:
> - if (!cpumask_test_cpu(arg.dst_cpu, &arg.src_task->cpus_allowed))
> + if ((!cpumask_test_cpu(arg.dst_cpu, &arg.src_task->cpus_allowed))
> + || !housekeeping_test_cpu(arg.dst_cpu, HK_FLAG_DOMAIN))
> goto out;

You did not read the comment I provided last time. Using isolcpus (and
thus it's renamed houskeeping thing) is the wrong thing to do. Load
balancing should be limited to it's root domain.

\
 
 \ /
  Last update: 2018-07-27 09:49    [W:0.130 / U:1.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site