Messages in this thread | | | From | Masahiro Yamada <> | Date | Sat, 28 Jul 2018 09:50:45 +0900 | Subject | Re: include architecture Kconfig files from top-level Kconfig v3 |
| |
2018-07-27 16:48 GMT+09:00 Christoph Hellwig <hch@lst.de>: > On Fri, Jul 27, 2018 at 10:32:19AM +0900, Masahiro Yamada wrote: >> This will just add a new unmet dependency warning. >> CONFIG_PREEMPT_COUNT will be still selected. > > True. I guess we simply need to prohibit CONFIG_DEBUG_ATOMIC_SLEEP > explicitly if PREEMPT_COUNT isn't supported. E.g something like this: > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index 26d3ff7e3cf4..373ce9fecd7e 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -1195,6 +1195,7 @@ config DEBUG_ATOMIC_SLEEP > bool "Sleep inside atomic section checking" > select PREEMPT_COUNT > depends on DEBUG_KERNEL > + depends on !ARCH_NO_PREEMPT > help > If you say Y here, various routines which may sleep will become very > noisy if they are called inside atomic sections: when a spinlock is
I will fold this into 07/10.
I see another 'select PREEMPT_COUNT' in drivers/gpu/drm/i915/Kconfig.debug but DRM_I915 depends on X86, so this is not a real problem.
-- Best Regards Masahiro Yamada
| |