Messages in this thread | | | From | Doug Anderson <> | Date | Thu, 26 Jul 2018 13:11:11 -0700 | Subject | Re: [RFT PATCH 0/4] usb: dwc2: Turn on uframe sched everywhere |
| |
Hi,
On Thu, Jul 26, 2018 at 3:59 AM, Felipe Balbi <felipe.balbi@linux.intel.com> wrote: > Douglas Anderson <dianders@chromium.org> writes: > >> While looking at a dwc2 recently, I noticed that some platforms still >> have the uframe scheduler off. As far as I know, nothing good can >> come out of having the uframe scheduler off. Let's turn it on >> everywhere. Assuming this all works out then some time in the future >> we can gut all the old code that handles the old non-uframe scheduler >> and make everything simpler. >> >> NOTE: I don't have access to any of the platforms that I'm changing >> here, so I'm hoping to see a Tested-by from those on the list. >> >> >> Douglas Anderson (4): >> usb: dwc2: Turn on uframe_sched on "bcm" platforms >> usb: dwc2: Turn on uframe_sched on "his" platforms >> usb: dwc2: Turn on uframe_sched on "amlogic" platforms >> usb: dwc2: Turn on uframe_sched on "stm32f4x9_fsotg" platforms > > care to resend without RFT prefix and with collected acks, tested-bys, etc?
Done with a prefix of 'REPOST' to hopefully make it obvious nothing changed between the RFT and this version. There were only two test-by, but as mentioned in the updated cover letter:
Since there should be nothing platform specific about the uFrame scheduler presumably this should mean we're good to go? Specificaly note that in at least one of the "Tested-by" reports this patch caused a notable improvement.
BTW: I'm pleased to have you apply the patches, but I notice that get_maintainer no longer flags you as the person to post dwc2 patches to. From linux-next:
$ ./scripts/get_maintainer.pl -f drivers/usb/dwc2 Minas Harutyunyan <hminas@synopsys.com> (maintainer:DESIGNWARE USB2 DRD IP DRIVER) Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:USB SUBSYSTEM) linux-usb@vger.kernel.org (open list:DESIGNWARE USB2 DRD IP DRIVER) linux-kernel@vger.kernel.org (open list)
-Doug
| |