Messages in this thread Patch in this message | | | From | Douglas Anderson <> | Subject | [REPOST PATCH 3/4] usb: dwc2: Turn on uframe_sched on "amlogic" platforms | Date | Thu, 26 Jul 2018 13:07:29 -0700 |
| |
There's no reason to have the uframe scheduler off on dwc2. Running with uframe_sched = False is equivalent to saying "I don't want to run the correct code, I want to run the old and incorrect code".
The uframe scheduler has been off on Amlogic since commit f94310ac076e ("usb: dwc2: add support for Meson8b and GXBB SoCs"). While this was after most of the recent improvements, notably the commit 9f9f09b048f5 ("usb: dwc2: host: Totally redo the microframe scheduler"), presumably the parameters were copied from another platform and the uframe scheduler wasn't tried.
Presumably if everyone is good w/ the uframe_sched turned back on we can kill all the old and crufty non-uframe sched code.
Signed-off-by: Douglas Anderson <dianders@chromium.org> ---
drivers/usb/dwc2/params.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c index db97bb16ecc4..93380f7c32b4 100644 --- a/drivers/usb/dwc2/params.c +++ b/drivers/usb/dwc2/params.c @@ -110,7 +110,6 @@ static void dwc2_set_amlogic_params(struct dwc2_hsotg *hsotg) p->phy_type = DWC2_PHY_TYPE_PARAM_UTMI; p->ahbcfg = GAHBCFG_HBSTLEN_INCR8 << GAHBCFG_HBSTLEN_SHIFT; - p->uframe_sched = false; } static void dwc2_set_amcc_params(struct dwc2_hsotg *hsotg) -- 2.18.0.345.g5c9ce644c3-goog
| |