Messages in this thread | | | Subject | Re: [PATCH v4 00/11] hugetlb: Factorize hugetlb architecture primitives | From | Mike Kravetz <> | Date | Thu, 26 Jul 2018 12:16:29 -0700 |
| |
On 07/26/2018 04:46 AM, Michael Ellerman wrote: > Mike Kravetz <mike.kravetz@oracle.com> writes: > >> On 07/20/2018 11:37 AM, Alex Ghiti wrote: >>> Does anyone have any suggestion about those patches ? >> >> I only took a quick look. From the hugetlb perspective, I like the >> idea of moving routines to a common file. If any of the arch owners >> (or anyone else) agree, I can do a review of the series. > > The conversions look pretty good to me. If you want to give it a review > then from my point of view it could go in -mm to shake out any bugs.
Nothing of significance found in a review. As others have suggested, the (cross)compiler may be better at finding issues than human eyes.
I also suggest it be added to -mm. -- Mike Kravetz
| |