lkml.org 
[lkml]   [2018]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mips: configs: remove no longer needed config option
Hi Anders,

On Thu, Jul 26, 2018 at 09:04:57AM +0200, Anders Roxell wrote:
> > Since commit eedf265aa003 ("devpts: Make each mount of devpts an
> > independent filesystem.") CONFIG_DEVPTS_MULTIPLE_INSTANCES isn't needed
> > in the defconfig anymore.
> >
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> > ---
> > arch/mips/configs/ip27_defconfig | 1 -
> > arch/mips/configs/nlm_xlp_defconfig | 1 -
> > arch/mips/configs/nlm_xlr_defconfig | 1 -
> > 3 files changed, 3 deletions(-)
>
> Ping.

Apologies - this was forgotten because it stopped showing up as
requiring action in patchwork after Ralf marked it as accepted, but it
has never been applied to the shared mips-next branch.

I do question whether it's worthwhile making these one-line changes to
configs, because:

1) The no presence of CONFIG_DEVPTS_MULTIPLE_INSTANCES is harmless
anyway, it'll just be ignored.

2) The configs in question will still not be up to date with a lot of
other changes since they were added.

Together these 2 things lead me to think that we'd be better to either:

a) Leave the defconfigs as-is, since the changes won't make them work
any better or worse.

b) Regenerate them entirely, such that they're up to date with not
just this Kconfig change but all of them.

Thanks,
Paul

\
 
 \ /
  Last update: 2018-07-26 19:52    [W:0.046 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site