lkml.org 
[lkml]   [2018]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH v3 2/2] fpga: zynq-fpga: Add support for readback
    Date
    Hi Alan,

    Thanks for the review...

    <Snip>
    > > In Zynq Case it supports two types of the readback (Configuration registers,
    > Configuration data(fpga image)) which may not be the same case for other
    > vendors.
    > > Since I need to support both the use cases I have differentiated them using
    > module param in the zynq-fpga driver.
    > >
    > > As you said we shouldn't change the attribute's function, So in the
    > > zynq-fpga driver, I am planning to add another debugfs attribute for
    > reading back of configuration registers as it is vendor specific readback type.
    > > (Configuration registers ---- Usage:
    > /sys/kernel/debug/fpga/zynq-fpga/cfgreg_summary)
    >
    > Is it called '...summary' because it is not all the registers? Could just be
    > "cfg_regs"?

    Sure will make it cfg_regs...
    Are you ok with the above proposal??
    if you are ok will make changes accordingly and will post v4...

    >
    > > (Configuration data(fpga image) ---- Usage:
    > /sys/kernel/debug/fpga/fpga0/image)
    > > Please let me know your thoughts for the same...
    > >
    > >>
    > >> > One other option is sysfs. Do you want me to implement sysfs path???
    > >> > Any other suggestions???
    > >>
    > >> You could implement another sysfs attribute for reading FPGA registers
    > >> with a separate ops callback. Please clarify what it is doing (not
    > >> all FPGAs have this function) and what that will look like when the
    > >> user reads the from the sysfs
    > >
    > > AFAIK we shouldn't add another sysfs/debugfs attribute for vendor-specific
    > readback type in the FPGA manager ops.
    > > Please correct me if my understanding is wrong.
    >
    > You are not wrong :)

    Thanks 😊

    Regards,
    Kedar.

    >
    > >
    > > Regards,
    > > Kedar.
    > >
    > >>
    > >> Alan
    \
     
     \ /
      Last update: 2018-07-26 07:21    [W:3.400 / U:0.976 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site