lkml.org 
[lkml]   [2018]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] net: fix amd-xgbe flow-control issue
From
Date
On 7/26/2018 1:45 AM, tli012345@163.com wrote:
> From: tangpengpeng <tangpengpeng@higon.com>
>
> If we enable or disable xgbe flow-control by ethtool ,
> it does't work.Because the parameter is not properly
> assigned,so we need to adjust the assignment order
> of the parameters.
>
> Signed-off-by: tangpengpeng <tangpengpeng@higon.com>

You should add a Fixes tag as this bug was introduced with commit:

c1ce2f77366b ("amd-xgbe: Fix flow control setting logic")

And since that commit was introduced in 4.2, you'll want to ask David to
push this to stable (4.4 and higher).

With that,

Acked-by: Tom Lendacky <thomas.lendacky@amd.com>

> ---
> drivers/net/ethernet/amd/xgbe/xgbe-mdio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
> index 4b5d625de8f0..8a3a60bb2688 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
> @@ -1111,14 +1111,14 @@ static void xgbe_phy_adjust_link(struct xgbe_prv_data *pdata)
>
> if (pdata->tx_pause != pdata->phy.tx_pause) {
> new_state = 1;
> - pdata->hw_if.config_tx_flow_control(pdata);
> pdata->tx_pause = pdata->phy.tx_pause;
> + pdata->hw_if.config_tx_flow_control(pdata);
> }
>
> if (pdata->rx_pause != pdata->phy.rx_pause) {
> new_state = 1;
> - pdata->hw_if.config_rx_flow_control(pdata);
> pdata->rx_pause = pdata->phy.rx_pause;
> + pdata->hw_if.config_rx_flow_control(pdata);
> }
>
> /* Speed support */
>

\
 
 \ /
  Last update: 2018-07-26 15:14    [W:0.049 / U:0.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site