lkml.org 
[lkml]   [2018]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v7 1/6] dt-bindings: mailbox: allow mbox-cells to be equal to 0
    On Thu, Jul 26, 2018 at 4:30 PM, A.s. Dong <aisheng.dong@nxp.com> wrote:
    >> -----Original Message-----
    >> From: Jassi Brar [mailto:jassisinghbrar@gmail.com]
    >> Sent: Thursday, July 26, 2018 5:42 PM
    >> To: Oleksij Rempel <o.rempel@pengutronix.de>
    >> Cc: Shawn Guo <shawnguo@kernel.org>; Fabio Estevam
    >> <fabio.estevam@nxp.com>; Rob Herring <robh+dt@kernel.org>; Mark
    >> Rutland <mark.rutland@arm.com>; A.s. Dong <aisheng.dong@nxp.com>;
    >> Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>; Sudeep Holla
    >> <sudeep.holla@arm.com>; Devicetree List <devicetree@vger.kernel.org>;
    >> Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; , Sascha Hauer
    >> <kernel@pengutronix.de>; , linux-arm-kernel@lists.infradead.org, linux-
    >> mediatek@lists.infradead.org, srv_heupstream <linux-arm-
    >> kernel@lists.infradead.org>; dl-linux-imx <linux-imx@nxp.com>
    >> Subject: Re: [PATCH v7 1/6] dt-bindings: mailbox: allow mbox-cells to be
    >> equal to 0
    >>
    >> On Thu, Jul 26, 2018 at 12:23 PM, Oleksij Rempel <o.rempel@pengutronix.de>
    >> wrote:
    >> > From: Dong Aisheng <aisheng.dong@nxp.com>
    >> >
    >> > Mailbox devices may have only one channel which means the mbox-cells
    >> > at least 1 does not make sense for this type devices. Let's remove
    >> > that limitation to allow the mbox-cells to be equal to 0.
    >> >
    >> OK
    >>
    >> But please realise that you'll have to write more code -- implement your own
    >> of_xlate() callback.
    >> Most developers would prefer to call the only channel as channel number 0,
    >> and use the common of_xlate implementation.
    >>
    >
    > Yes, that's true because the common of_xlate assuming the mbox-cells is 1.
    > And there's already such users:
    > arch/arm/boot/dts/bcm283x.dtsi
    >
    You mean that is a good thing, right?

    \
     
     \ /
      Last update: 2018-07-26 13:37    [W:2.248 / U:0.864 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site