lkml.org 
[lkml]   [2018]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [f2fs-dev] [PATCH] f2fs: fix 32-bit format string warning
On Wed, Jul 25, 2018 at 5:21 PM, Chao Yu <chao@kernel.org> wrote:
> On 2018/7/24 17:34, Arnd Bergmann wrote:
>> On 32-bit targets, size_t is often 'unsigned int', so printing it as %lu
>> causes a warning:
>>
>> fs/f2fs/inode.c: In function 'sanity_check_inode':
>> fs/f2fs/inode.c:247:4: error: format '%lu' expects argument of type 'long unsigned int', but argument 7 has type 'unsigned int' [-Werror=format=]
>>
>> The correct format string is %zu.
>>
>> Fixes: ba3a252d3367 ("f2fs: fix to do sanity check with i_extra_isize")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> I noticed the issue, thank you for fixing it, but original buggy patch has not
> been upstreamed yet, how about merging this fix into origial patch, if you don't
> mind?

Yes, please do that.

Arnd

\
 
 \ /
  Last update: 2018-07-25 21:37    [W:0.062 / U:0.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site