Messages in this thread | | | From | Linus Torvalds <> | Date | Tue, 24 Jul 2018 13:15:21 -0700 | Subject | Re: [PATCH 20/20] signal: Don't restart fork when signals come in. |
| |
On Tue, Jul 24, 2018 at 1:05 PM Eric W. Biederman <ebiederm@xmission.com> wrote: > > What I hear you asking is moving up copy_signal copy_sighand copy_creds > and alloc_pid, and anything else that signal delivery might depend on.
No, _just_ signal allocation.
It would still just use the special-case list to set the pending bit. No creds, no "full task", nothing like that.
> I really want something very simple and straight forward because I don't > see us testing or hitting this code path much in practice. Moving this > into the middle of fork and adding more depedencies does not seem like > it will be that kind of straight forward.
I think your "list on the stack" was anything but straightforward, considering how utterly broken the error handling of the patch was.
But hey., send a fixed patch and see how it looks. I think you'll end up adding a lot of "goto signal_cleanup" cases.
Linus
| |