Messages in this thread | | | Date | Tue, 24 Jul 2018 13:43:34 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH 4/5] sh: split arch/sh/mm/consistent.c |
| |
On Mon, Jul 23, 2018 at 10:49:39AM +0200, Geert Uytterhoeven wrote: > > > + *dma_handle = virt_to_phys(ret); > > > + if (!WARN_ON(!dev)) > > > + *dma_handle - PFN_PHYS(dev->dma_pfn_offset); > > vs > > > - *dma_handle = virt_to_phys(ret); > > > - if (!WARN_ON(!dev)) > > > - *dma_handle -= PFN_PHYS(dev->dma_pfn_offset); > > Doesn't look right to me, neither. > > No complaints for 0day? My gcc says: > > error: statement with no effect [-Werror=unused-value]
For some reason 0day has failed me multiple times for sh. Does the 0day bot even cover sh at all?
| |