lkml.org 
[lkml]   [2018]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 07/12] i2c: stu300: use core to detect 'no zero length' quirk
    Date
    And don't reimplement in the driver.

    Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
    ---

    Only build tested.

    drivers/i2c/busses/i2c-stu300.c | 12 ++++++------
    1 file changed, 6 insertions(+), 6 deletions(-)

    diff --git a/drivers/i2c/busses/i2c-stu300.c b/drivers/i2c/busses/i2c-stu300.c
    index fce52bdab2b7..5503fa171df0 100644
    --- a/drivers/i2c/busses/i2c-stu300.c
    +++ b/drivers/i2c/busses/i2c-stu300.c
    @@ -673,12 +673,6 @@ static int stu300_xfer_msg(struct i2c_adapter *adap,
    msg->addr, msg->len, msg->flags, stop);
    }

    - /* Zero-length messages are not supported by this hardware */
    - if (msg->len == 0) {
    - ret = -EINVAL;
    - goto exit_disable;
    - }
    -
    /*
    * For some reason, sending the address sometimes fails when running
    * on the 13 MHz clock. No interrupt arrives. This is a work around,
    @@ -863,6 +857,10 @@ static const struct i2c_algorithm stu300_algo = {
    .functionality = stu300_func,
    };

    +static const struct i2c_adapter_quirks stu300_quirks = {
    + .flags = I2C_AQ_NO_ZERO_LEN,
    +};
    +
    static int stu300_probe(struct platform_device *pdev)
    {
    struct stu300_dev *dev;
    @@ -920,6 +918,8 @@ static int stu300_probe(struct platform_device *pdev)
    adap->algo = &stu300_algo;
    adap->dev.parent = &pdev->dev;
    adap->dev.of_node = pdev->dev.of_node;
    + adap->quirks = &stu300_quirks;
    +
    i2c_set_adapdata(adap, dev);

    /* i2c device drivers may be active on return from add_adapter() */
    --
    2.11.0
    \
     
     \ /
      Last update: 2018-07-23 22:28    [W:4.130 / U:0.416 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site