Messages in this thread | | | Date | Sun, 22 Jul 2018 11:39:58 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 05/11] touchscreen: elants: Use octal permissions |
| |
On Sun, Jul 22, 2018 at 12:39:45AM +0530, dev-harsh1998 wrote: > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. > +static DEVICE_ATTR(iap_mode, S_IRUGO, show_iap_mode, NULL); > > WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'. > +static DEVICE_ATTR(update_fw, S_IWUSR, NULL, write_update_fw) > > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. > + .dattr = __ATTR(_field, S_IRUGO, \ > > Signed-off-by: dev-harsh1998 <harshitjain6751@gmail.com>
You need to use your real name when creating Linux kernel patches.
thanks,
greg k-h
| |