Messages in this thread | | | Date | Sun, 22 Jul 2018 10:12:46 +0200 | From | Florian Westphal <> | Subject | Re: [PATCH] netlink: fix memory leak |
| |
Jason A. Donenfeld <Jason@zx2c4.com> wrote: > On Sun, Jul 22, 2018 at 4:51 AM Shaochun Chen <cscnull@gmail.com> wrote: > But even if you moved it somehow to the if(ret), I'm still not sure > it'd be correct; start cbs should either succeed, or they should error > out and cleanup entirely after themselves.
I agree, ->done() should not be called if cb->dump() was never invoked.
All ctnetlink and nf_tables spots need to cleanup after themselves.
| |