lkml.org 
[lkml]   [2018]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] tty: Make constants to be enums instead of #define in goldfish.c
On Tue, Jul 17, 2018 at 05:14:54PM -0700, rkir@google.com wrote:
> From: Roman Kiryanov <rkir@google.com>
>
> enums produce better compilation errors than defines.

Yes, if you name the enum. But you didn't do that here, so this patch
really does not do anything to cause any "protection" at all :(

Please fix this up and resend.

thanks,

greg k-h

\
 
 \ /
  Last update: 2018-07-21 09:46    [W:0.109 / U:0.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site