Messages in this thread | | | Date | Sat, 21 Jul 2018 09:45:21 +0200 | From | Greg KH <> | Subject | Re: [PATCH 2/3] tty: Make constants to be enums instead of #define in goldfish.c |
| |
On Tue, Jul 17, 2018 at 05:14:54PM -0700, rkir@google.com wrote: > From: Roman Kiryanov <rkir@google.com> > > enums produce better compilation errors than defines.
Yes, if you name the enum. But you didn't do that here, so this patch really does not do anything to cause any "protection" at all :(
Please fix this up and resend.
thanks,
greg k-h
| |