Messages in this thread | | | Subject | Re: [PATCH] drivers/memory/Kconfig: Add CONFIG_OF dependency | From | Randy Dunlap <> | Date | Sat, 21 Jul 2018 14:53:47 -0700 |
| |
On 07/21/2018 01:00 PM, Anders Roxell wrote: > JZ4780_NEMC doesn't depend on OF, and if OF isn't enabled we get this > error: > drivers/memory/jz4780-nemc.c: In function ‘jz4780_nemc_num_banks’: > drivers/memory/jz4780-nemc.c:72:10: error: implicit declaration of > function ‘of_read_number’; did you mean ‘down_read_nested’? > [-Werror=implicit-function-declaration] > bank = of_read_number(prop, 1); > ^~~~~~~~~~~~~~ > down_read_nested > > Make JZ4780_NEMC depend on OF. > > Fixes: ab99e11062c1 ("memory: jz4780-nemc: Allow selection of this driver when COMPILE_TEST=y") > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> --- > drivers/memory/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig > index a642552dfdc9..63389f075f1d 100644 > --- a/drivers/memory/Kconfig > +++ b/drivers/memory/Kconfig > @@ -123,7 +123,7 @@ config JZ4780_NEMC > bool "Ingenic JZ4780 SoC NEMC driver" > default y > depends on MACH_JZ4780 || COMPILE_TEST > - depends on HAS_IOMEM > + depends on HAS_IOMEM && OF > help > This driver is for the NAND/External Memory Controller (NEMC) in > the Ingenic JZ4780. This controller is used to handle external >
-- ~Randy
| |