Messages in this thread |  | | Date | Fri, 20 Jul 2018 17:15:18 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 3/4] perf tools: Fix check-headers.sh output file variables |
| |
On Fri, Jul 20, 2018 at 11:57:45AM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Jul 20, 2018 at 01:00:35PM +0200, Jiri Olsa escreveu: > > The warning message in check_w function uses wrongly > > the $file variable instead of $file1 and $file2. > > Humm, > > Before: > > Warning: Kernel ABI header at 'tools/arch/powerpc/include/uapi/asm/unistd.h' differs from latest version at 'arch/powerpc/include/uapi/asm/unistd.h' > > After: > > Warning: Kernel ABI header at '../arch/powerpc/include/uapi/asm/unistd.h' differs from latest version at '../../arch/powerpc/include/uapi/asm/unistd.h' > > > The previous version is better, I can then just use: > > diff -u tools/arch/powerpc/include/uapi/asm/unistd.h arch/powerpc/include/uapi/asm/unistd.h > > and get what changed, with your change I have to go to tools/perf before > doing that diff, which is an unnecessary extra step in at least my > workflow.
so all paths output based in kernel tree root then, will change
jirka
|  |