Messages in this thread Patch in this message | | | Date | Fri, 20 Jul 2018 12:03:54 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 4/4] perf tools: Move syscall_64.tbl check into check-headers.sh |
| |
Em Fri, Jul 20, 2018 at 01:00:36PM +0200, Jiri Olsa escreveu: > Probably leftover from the time we introducd the check-headers.sh script.
So, with your patch:
[acme@jouet perf]$ git diff diff --git a/arch/x86/entry/syscalls/syscall_64.tbl b/arch/x86/entry/syscalls/syscall_64.tbl index f0b1709a5ffb..cfc1b0949bb1 100644 --- a/arch/x86/entry/syscalls/syscall_64.tbl +++ b/arch/x86/entry/syscalls/syscall_64.tbl @@ -343,6 +343,7 @@ 332 common statx __x64_sys_statx 333 common io_pgetevents __x64_sys_io_pgetevents 334 common rseq __x64_sys_rseq +335 common krava __x64_sys_krava # # x32-specific system call numbers start at 512 to avoid cache impact [acme@jouet perf]$
It doesn't warn about that new cool syscall, without your patch:
Warning: Kernel ABI header at 'tools/perf/arch/x86/entry/syscalls/syscall_64.tbl' differs from latest version at 'arch/x86/entry/syscalls/syscall_64.tbl'
Can you check this?
- Arnaldo
> Link: http://lkml.kernel.org/n/tip-oh56ckqztoc07we7mtdphu7r@git.kernel.org > Signed-off-by: Jiri Olsa <jolsa@kernel.org> > --- > tools/perf/arch/x86/Makefile | 3 --- > tools/perf/check-headers.sh | 3 +++ > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/arch/x86/Makefile b/tools/perf/arch/x86/Makefile > index 1a38e78117ce..8cc6642fce7a 100644 > --- a/tools/perf/arch/x86/Makefile > +++ b/tools/perf/arch/x86/Makefile > @@ -19,9 +19,6 @@ systbl := $(sys)/syscalltbl.sh > _dummy := $(shell [ -d '$(out)' ] || mkdir -p '$(out)') > > $(header): $(sys)/syscall_64.tbl $(systbl) > - @(test -d ../../kernel -a -d ../../tools -a -d ../perf && ( \ > - (diff -B arch/x86/entry/syscalls/syscall_64.tbl ../../arch/x86/entry/syscalls/syscall_64.tbl >/dev/null) \ > - || echo "Warning: Kernel ABI header at 'tools/perf/arch/x86/entry/syscalls/syscall_64.tbl' differs from latest version at 'arch/x86/entry/syscalls/syscall_64.tbl'" >&2 )) || true > $(Q)$(SHELL) '$(systbl)' $(sys)/syscall_64.tbl 'x86_64' > $@ > > clean:: > diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh > index 73e723675c5f..2c10e46d98e9 100755 > --- a/tools/perf/check-headers.sh > +++ b/tools/perf/check-headers.sh > @@ -93,3 +93,6 @@ check arch/x86/lib/memcpy_64.S '-I "^EXPORT_SYMBOL" -I "^#include <asm/ex > check arch/x86/lib/memset_64.S '-I "^EXPORT_SYMBOL" -I "^#include <asm/export.h>"' > check include/uapi/asm-generic/mman.h '-I "^#include <\(uapi/\)*asm-generic/mman-common.h>"' > check include/uapi/linux/mman.h '-I "^#include <\(uapi/\)*asm/mman.h>"' > + > +# diff non-symmetric files > +check_2 arch/x86/entry/syscalls/syscall_64.tbl ../../arch/x86/entry/syscalls/syscall_64.tbl > -- > 2.17.1
| |