lkml.org 
[lkml]   [2018]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.17 040/101] stmmac: fix DMA channel hang in half-duplex mode
    Date
    4.17-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Bhadram Varka <vbhadram@nvidia.com>

    [ Upstream commit b6cfffa7ad923c73f317ea50fd4ebcb3b4b6669c ]

    HW does not support Half-duplex mode in multi-queue
    scenario. Fix it by not advertising the Half-Duplex
    mode if multi-queue enabled.

    Signed-off-by: Bhadram Varka <vbhadram@nvidia.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 10 ++++++++++
    1 file changed, 10 insertions(+)

    --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
    +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
    @@ -927,6 +927,7 @@ static void stmmac_check_pcs_mode(struct
    static int stmmac_init_phy(struct net_device *dev)
    {
    struct stmmac_priv *priv = netdev_priv(dev);
    + u32 tx_cnt = priv->plat->tx_queues_to_use;
    struct phy_device *phydev;
    char phy_id_fmt[MII_BUS_ID_SIZE + 3];
    char bus_id[MII_BUS_ID_SIZE];
    @@ -968,6 +969,15 @@ static int stmmac_init_phy(struct net_de
    SUPPORTED_1000baseT_Full);

    /*
    + * Half-duplex mode not supported with multiqueue
    + * half-duplex can only works with single queue
    + */
    + if (tx_cnt > 1)
    + phydev->supported &= ~(SUPPORTED_1000baseT_Half |
    + SUPPORTED_100baseT_Half |
    + SUPPORTED_10baseT_Half);
    +
    + /*
    * Broken HW is sometimes missing the pull-up resistor on the
    * MDIO line, which results in reads to non-existent devices returning
    * 0 rather than 0xffff. Catch this here and treat 0 as a non-existent

    \
     
     \ /
      Last update: 2018-07-20 14:51    [W:4.404 / U:0.248 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site