Messages in this thread | | | Date | Thu, 19 Jul 2018 16:01:02 +0200 | From | Borislav Petkov <> | Subject | Re: [RFC PATCH] EDAC, ghes: Enable per-layer error reporting for ARM |
| |
On Mon, Jul 16, 2018 at 01:26:49PM -0400, Tyler Baicar wrote: > Enable per-layer error reporting for ARM systems so that the error > counters are incremented per-DIMM. > > On ARM systems that use firmware first error handling it is understood > that card=channel and module=DIMM on that channel. Populate that > information and enable per layer error reporting for ARM systems so that > the EDAC error counters are incremented based on DIMM number as per the > SMBIOS table rather than just incrementing the noinfo counters on the > memory controller.
I guess.
James?
> Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org> > --- > drivers/edac/ghes_edac.c | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c > index 473aeec..e4c8b6e 100644 > --- a/drivers/edac/ghes_edac.c > +++ b/drivers/edac/ghes_edac.c > @@ -213,9 +213,18 @@ void ghes_edac_report_mem_error(int sev, struct cper_sec_mem_err *mem_err) > strcpy(e->label, "unknown label"); > e->msg = pvt->msg; > e->other_detail = pvt->other_detail; > - e->top_layer = -1; > - e->mid_layer = -1; > - e->low_layer = -1;
<----- newline here.
> + if ((IS_ENABLED(CONFIG_ARM) || IS_ENABLED(CONFIG_ARM64)) > + && (mem_err->validation_bits & CPER_MEM_VALID_CARD) > + && (mem_err->validation_bits & CPER_MEM_VALID_MODULE)) { > + e->top_layer = mem_err->card; > + e->mid_layer = mem_err->module; > + e->low_layer = -1; > + e->enable_per_layer_report = true; > + } else { > + e->top_layer = -1; > + e->mid_layer = -1; > + e->low_layer = -1; > + }
ditto.
> *pvt->other_detail = '\0'; > *pvt->msg = '\0'; > > --
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply. --
| |