Messages in this thread | | | Subject | Re: [PATCH v1] lib: Remove 'default n' in Kconfig for tests | From | Coly Li <> | Date | Thu, 19 Jul 2018 21:10:25 +0800 |
| |
On 2018/7/19 4:51 PM, Andy Shevchenko wrote: > It seems contributors follow the style of Kconfig entries where explicit > 'default n' is present. The default 'default' is 'n' already, thus, drop > these lines from Kconfig to make it more clear. > > Cc: Coly Li <colyli@suse.de> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Coly Li <colyli@suse.de>
Thanks.
Coly Li
> --- > lib/Kconfig | 1 - > lib/Kconfig.debug | 17 ----------------- > 2 files changed, 18 deletions(-) > > diff --git a/lib/Kconfig b/lib/Kconfig > index 031655d26dce..40bfa6ccd294 100644 > --- a/lib/Kconfig > +++ b/lib/Kconfig > @@ -231,7 +231,6 @@ config AUDIT_COMPAT_GENERIC > > config RANDOM32_SELFTEST > bool "PRNG perform self test on init" > - default n > help > This option enables the 32 bit PRNG library functions to perform a > self test on initialization. > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index c731ff97500c..244c08055d8e 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -1225,7 +1225,6 @@ config LOCK_TORTURE_TEST > tristate "torture tests for locking" > depends on DEBUG_KERNEL > select TORTURE_TEST > - default n > help > This option provides a kernel module that runs torture tests > on kernel locking primitives. The kernel module may be built > @@ -1692,7 +1691,6 @@ config LKDTM > tristate "Linux Kernel Dump Test Tool Module" > depends on DEBUG_FS > depends on BLOCK > - default n > help > This module enables testing of the different dumping mechanisms by > inducing system failures at predefined crash points. > @@ -1726,7 +1724,6 @@ config KPROBES_SANITY_TEST > bool "Kprobes sanity tests" > depends on DEBUG_KERNEL > depends on KPROBES > - default n > help > This option provides for testing basic kprobes functionality on > boot. Samples of kprobe and kretprobe are inserted and > @@ -1737,7 +1734,6 @@ config KPROBES_SANITY_TEST > config BACKTRACE_SELF_TEST > tristate "Self test for the backtrace code" > depends on DEBUG_KERNEL > - default n > help > This option provides a kernel module that can be used to test > the kernel stack backtrace code. This option is not useful > @@ -1807,7 +1803,6 @@ config TEST_PRINTF > > config TEST_BITMAP > tristate "Test bitmap_*() family of functions at runtime" > - default n > help > Enable this option to test the bitmap functions at boot. > > @@ -1831,7 +1826,6 @@ config TEST_OVERFLOW > > config TEST_RHASHTABLE > tristate "Perform selftest on resizable hash table" > - default n > help > Enable this option to test the rhashtable functions at boot. > > @@ -1839,7 +1833,6 @@ config TEST_RHASHTABLE > > config TEST_HASH > tristate "Perform selftest on hash functions" > - default n > help > Enable this option to test the kernel's integer (<linux/hash.h>), > string (<linux/stringhash.h>), and siphash (<linux/siphash.h>) > @@ -1853,7 +1846,6 @@ config TEST_IDA > > config TEST_PARMAN > tristate "Perform selftest on priority array manager" > - default n > depends on PARMAN > help > Enable this option to test priority array manager on boot > @@ -1863,7 +1855,6 @@ config TEST_PARMAN > > config TEST_LKM > tristate "Test module loading with 'hello world' module" > - default n > depends on m > help > This builds the "test_module" module that emits "Hello, world" > @@ -1877,7 +1868,6 @@ config TEST_LKM > > config TEST_USER_COPY > tristate "Test user/kernel boundary protections" > - default n > depends on m > help > This builds the "test_user_copy" module that runs sanity checks > @@ -1890,7 +1880,6 @@ config TEST_USER_COPY > > config TEST_BPF > tristate "Test BPF filter functionality" > - default n > depends on m && NET > help > This builds the "test_bpf" module that runs various test vectors > @@ -1904,7 +1893,6 @@ config TEST_BPF > > config FIND_BIT_BENCHMARK > tristate "Test find_bit functions" > - default n > help > This builds the "test_find_bit" module that measure find_*_bit() > functions performance. > @@ -1913,7 +1901,6 @@ config FIND_BIT_BENCHMARK > > config TEST_FIRMWARE > tristate "Test firmware loading via userspace interface" > - default n > depends on FW_LOADER > help > This builds the "test_firmware" module that creates a userspace > @@ -1926,7 +1913,6 @@ config TEST_FIRMWARE > > config TEST_SYSCTL > tristate "sysctl test driver" > - default n > depends on PROC_SYSCTL > help > This builds the "test_sysctl" module. This driver enables to test the > @@ -1937,7 +1923,6 @@ config TEST_SYSCTL > > config TEST_UDELAY > tristate "udelay test driver" > - default n > help > This builds the "udelay_test" module that helps to make sure > that udelay() is working properly. > @@ -1946,7 +1931,6 @@ config TEST_UDELAY > > config TEST_STATIC_KEYS > tristate "Test static keys" > - default n > depends on m > help > Test the static key interfaces. > @@ -1955,7 +1939,6 @@ config TEST_STATIC_KEYS > > config TEST_KMOD > tristate "kmod stress tester" > - default n > depends on m > depends on BLOCK && (64BIT || LBDAF) # for XFS, BTRFS > depends on NETDEVICES && NET_CORE && INET # for TUN >
| |