lkml.org 
[lkml]   [2018]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next v4 2/3] media: ov772x: use SCCB regmap

> > -static int ov772x_mask_set(struct i2c_client *client, u8 command, u8 mask,
> > - u8 set)
> > -{
> > - s32 val = ov772x_read(client, command);
> > -
> > - if (val < 0)
> > - return val;
> > -
> > - val &= ~mask;
> > - val |= set & mask;
> > -
> > - return ov772x_write(client, command, val);
> > -}
> > -
>
> If I were you I would have kept these functions and wrapped the regmap
> operations there. This is not an issue though if you prefer it this
> way :)

I have suggested this way. It is not a show stopper issue, but I still
like this version better.

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-07-19 10:43    [W:0.154 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site