lkml.org 
[lkml]   [2018]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 4/8] swap: Unify normal/huge code path in swap_page_trans_huge_swapped()
Date
Christoph Hellwig <hch@infradead.org> writes:

>> static inline bool cluster_is_huge(struct swap_cluster_info *info)
>> {
>> - return info->flags & CLUSTER_FLAG_HUGE;
>> + if (IS_ENABLED(CONFIG_THP_SWAP))
>> + return info->flags & CLUSTER_FLAG_HUGE;
>> + else
>> + return false;
>
> Nitpick: no need for an else after a return:
>
> if (IS_ENABLED(CONFIG_THP_SWAP))
> return info->flags & CLUSTER_FLAG_HUGE;
> return false;

Sure. Will change this in next version.

Best Regards,
Huang, Ying

\
 
 \ /
  Last update: 2018-07-20 02:27    [W:1.794 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site