lkml.org 
[lkml]   [2018]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] powerpc/prom_init: remove linux,stdout-package property
On Wed, Jul 18, 2018 at 07:37:37PM +1000, Michael Ellerman wrote:
> Hi Murilo,
>
> Thanks for the patch.
>
> Murilo Opsfelder Araujo <muriloo@linux.ibm.com> writes:
> > This property was added in 2004 by
> >
> > https://github.com/mpe/linux-fullhistory/commit/689fe5072fe9a0dec914bfa4fa60aed1e54563e6
> >
> > and the only use of it, which was already inside `#if 0`, was removed a month
> > later by
> >
> > https://github.com/mpe/linux-fullhistory/commit/1fbe5a6d90f6cd4ea610737ef488719d1a875de7
> >
> > Fixes: https://github.com/linuxppc/linux/issues/125
>
> That is going to confuse some scripts that are expecting that to be a
> "Fixes: <some commit>" tag :)
>
> The proper tag to use there would be "Link:".
>
> But, I'd prefer we didn't add github issue links to the history, as I'm
> not sure they won't bit-rot eventually. Not because I'm a anti-Microsoft
> conspiracy person but just because it's a repo I set up and manage and
> there's no long term plan for it necessarily.
>
> > ---
> > arch/powerpc/kernel/prom_init.c | 2 --
> > 1 file changed, 2 deletions(-)
>
> Including the link here would be ideal, as it means it doesn't end up in
> the commit history, but it does end up in the mail archive. So if we
> ever really need to find it, it should be there.
>
> cheers

Hi, Michael.

Thanks for reviewing it. I've sent v2 with your suggestions:

https://lkml.kernel.org/r/20180718161544.12134-1-muriloo@linux.ibm.com

Cheers

--
Murilo

\
 
 \ /
  Last update: 2018-07-18 18:22    [W:0.048 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site