Messages in this thread | | | Subject | Re: [PATCH] Bluetooth:hci_bcm:Check return value from devm_clk_get | From | Marcel Holtmann <> | Date | Wed, 18 Jul 2018 14:09:55 +0200 |
| |
Hi Raghu,
> * Check return value from devm_clk_get & return appropriate error. > --- > drivers/bluetooth/hci_bcm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c > index 441f5e1deb11..1295cc89d702 100644 > --- a/drivers/bluetooth/hci_bcm.c > +++ b/drivers/bluetooth/hci_bcm.c > @@ -910,6 +910,8 @@ static int bcm_get_resources(struct bcm_device *dev) > return 0; > > dev->clk = devm_clk_get(dev->dev, NULL); > + if (IS_ERR(dev->clk)) > + return PTR_ERR(dev->clk);
so I assumed this was not done on purpose and allow for dev->clk = NULL since all other clock handling functions will cope with it. Can someone NAK or ACK this patch?
Regards
Marcel
| |