lkml.org 
[lkml]   [2018]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: linux-next: build failure after merge of the ida tree
    On Wed, Jul 18, 2018 at 11:24:26AM +0200, Pablo Neira Ayuso wrote:
    > I see, we have no more lockless API for IDA anymore :-(. In our case,
    > we were already protected by the the nfnl_lock mutex, which it was
    > sufficient to ensure non-concurrent access to IDA structures.

    You're actually the first user for whom this is true. For every other
    user, the requirement to manage their own spinlock was a pain.

    > Unless I'm missing anything, the new API forces use to the spinlock
    > call with disabled irq for each time we update something from the
    > netfilter netlink interface, so that's a no-go for us.

    I can't believe that's a serious problem for you, though. You're calling
    sscanf(), this can't possibly be a performance path.

    \
     
     \ /
      Last update: 2018-07-18 14:00    [W:4.009 / U:0.532 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site