Messages in this thread | | | Date | Wed, 18 Jul 2018 13:59:05 +0200 | From | Joerg Roedel <> | Subject | Re: [PATCH 10/39] x86/entry/32: Handle Entry from Kernel-Mode on Entry-Stack |
| |
On Tue, Jul 17, 2018 at 01:06:11PM -0700, Andy Lutomirski wrote: > Yes, we obviously need to restore the correct cr3. But I really don't > like the code that rewrites the stack frame that we're about to IRET > to, especially when it doesn't seem to serve a purpose. I'd much > rather the code just get its CR3 right and do the IRET and trust that > the frame it's returning to is still there.
Okay, I'll give it a try and if it works without the copying we can put that on-top of this patch-set. This also has the benefit that we can revert it later if it causes problems down the road.
Regards,
Joerg
| |