lkml.org 
[lkml]   [2018]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 17/32] staging: gasket: annotate ioctl arg with __user
On Tue, Jul 17, 2018 at 3:26 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Mon, Jul 16, 2018 at 07:09:11PM -0700, Todd Poynor wrote:
>> @@ -629,7 +630,6 @@ static bool is_gcb_in_reset(struct gasket_dev *gasket_dev)
>> */
>> static uint apex_ioctl_check_permissions(struct file *filp, uint cmd)
>> {
>> - struct gasket_dev *gasket_dev = filp->private_data;
>> fmode_t write;
>>
>> write = filp->f_mode & FMODE_WRITE;
>
> This should have gone in the earlier patch. When you spot something
> like that then create a separate patch for it and use `git rebase -i` to
> fold it back into the original.

Oopsie, thanks.

>
> regards,
> dan carpenter
>



--
Todd

\
 
 \ /
  Last update: 2018-07-17 20:21    [W:0.069 / U:0.928 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site