Messages in this thread | | | From | Miklos Szeredi <> | Date | Tue, 17 Jul 2018 16:47:29 +0200 | Subject | Re: [PATCH 2/2] fs/fuse, splice_write: reduce allocation size. |
| |
On Mon, Jul 16, 2018 at 6:03 PM, Andrey Ryabinin <aryabinin@virtuozzo.com> wrote: > The 'bufs' array contains 'pipe->buffers' elements, but the > fuse_dev_splice_write() uses only 'pipe->nrbufs' elements.
Hmm, only valid with pipe lock held, AFAICS.
True for using ->buffers as well...
Would you mind resending this series with an additional starting patch that moves the bufs allocations inside pipe_lock()/pipe_unlock() to fix races with fcntl(F_SETPIPE_SZ).
Thanks, Miklos
| |