Messages in this thread | | | Subject | Re: [PATCH 2/2] i2c: designware: Add support for a bus clock | From | Andy Shevchenko <> | Date | Tue, 17 Jul 2018 17:18:32 +0300 |
| |
On Tue, 2018-07-17 at 12:42 +0000, Phil Edworthy wrote:
> > While your point sounds valid (don't remember how clk_get() is > > implemented), NULL is also OK to have. > > Ok as in there is no bus clock, right? > So it should be: > if (!IS_ERR_OR_NULL (dev->busclk))
Nope, NULL is no error case for optional clock.
-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
| |