lkml.org 
[lkml]   [2018]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 1/5] mm/sparse: abstract sparse buffer allocations
On Mon, Jul 16, 2018 at 01:44:43PM -0400, Pavel Tatashin wrote:
> When struct pages are allocated for sparse-vmemmap VA layout, we first try
> to allocate one large buffer, and than if that fails allocate struct pages
> for each section as we go.
>
> The code that allocates buffer is uses global variables and is spread
> across several call sites.
>
> Cleanup the code by introducing three functions to handle the global
> buffer:
>
> sparse_buffer_init() initialize the buffer
> sparse_buffer_fini() free the remaining part of the buffer
> sparse_buffer_alloc() alloc from the buffer, and if buffer is empty
> return NULL
>
> Define these functions in sparse.c instead of sparse-vmemmap.c because
> later we will use them for non-vmemmap sparse allocations as well.
>
> Signed-off-by: Pavel Tatashin <pasha.tatashin@oracle.com>

I did not see anything wrong, so:

Reviewed-by: Oscar Salvador <osalvador@suse.de>

Thanks
--
Oscar Salvador
SUSE L3

\
 
 \ /
  Last update: 2018-07-17 13:45    [W:0.072 / U:1.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site