lkml.org 
[lkml]   [2018]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[tip:irq/core] genirq: Remove redundant NULL pointer check in __free_irq()
Commit-ID:  d91cfeb0aa79445fcfa9f523a5b57c5e9f4113ec
Gitweb: https://git.kernel.org/tip/d91cfeb0aa79445fcfa9f523a5b57c5e9f4113ec
Author: RAGHU Halharvi <raghuhack78@gmail.com>
AuthorDate: Tue, 17 Jul 2018 15:50:09 +0530
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 17 Jul 2018 13:35:44 +0200

genirq: Remove redundant NULL pointer check in __free_irq()

The NULL pointer check in __free_irq() triggers a 'dereference before NULL
pointer check' warning in static code analysis. It turns out that the check
is redundant because all callers have a NULL pointer check already.

Remove it.

Signed-off-by: RAGHU Halharvi <raghuhack78@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20180717102009.7708-1-raghuhack78@gmail.com

---
kernel/irq/manage.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 1f8be33572a7..a66c58f91bff 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -1570,9 +1570,6 @@ static struct irqaction *__free_irq(struct irq_desc *desc, void *dev_id)

WARN(in_interrupt(), "Trying to free IRQ %d from IRQ context!\n", irq);

- if (!desc)
- return NULL;
-
mutex_lock(&desc->request_mutex);
chip_bus_lock(desc);
raw_spin_lock_irqsave(&desc->lock, flags);
\
 
 \ /
  Last update: 2018-07-17 13:40    [W:0.465 / U:2.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site