lkml.org 
[lkml]   [2018]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v14 1/2] Reorganize the oom report in dump_header
On Tue 17-07-18 19:05:47, ufo19890607@gmail.com wrote:
> From: yuzhoujian <yuzhoujian@didichuxing.com>
>
> OOM report contains several sections. The first one is the allocation
> context that has triggered the OOM. Then we have cpuset context
> followed by the stack trace of the OOM path. Followed by the oom
> eligible tasks and the information about the chosen oom victim.
>
> One thing that makes parsing more awkward than necessary is that we do
> not have a single and easily parsable line about the oom context. This
> patch is reorganizing the oom report to
> 1) who invoked oom and what was the allocation request
> [ 131.751307] panic invoked oom-killer: gfp_mask=0x6280ca(GFP_HIGHUSER_MOVABLE|__GFP_ZERO), order=0, oom_score_adj=0
>
> 2) OOM stack trace
> [ 131.752399] CPU: 16 PID: 8581 Comm: panic Not tainted 4.18.0-rc5+ #48
> [ 131.753154] Hardware name: Inspur SA5212M4/YZMB-00370-107, BIOS 4.1.10 11/14/2016
> [ 131.753806] Call Trace:
> [ 131.754473] dump_stack+0x5a/0x73
> [ 131.755129] dump_header+0x53/0x2dc
> [ 131.755775] oom_kill_process+0x228/0x420
> [ 131.756430] ? oom_badness+0x2a/0x130
> [ 131.757063] out_of_memory+0x11a/0x4a0
> [ 131.757710] __alloc_pages_slowpath+0x7cc/0xa1e
> [ 131.758392] ? apic_timer_interrupt+0xa/0x20
> [ 131.759040] __alloc_pages_nodemask+0x277/0x290
> [ 131.759710] alloc_pages_vma+0x73/0x180
> [ 131.760388] do_anonymous_page+0xed/0x5a0
> [ 131.761067] __handle_mm_fault+0xbb3/0xe70
> [ 131.761749] handle_mm_fault+0xfa/0x210
> [ 131.762457] __do_page_fault+0x233/0x4c0
> [ 131.763136] do_page_fault+0x32/0x140
> [ 131.763832] ? page_fault+0x8/0x30
> [ 131.764523] page_fault+0x1e/0x30
>
> 3) oom context (contrains and the chosen victim).
> [ 131.771164] oom-kill:constraint=CONSTRAINT_NONE,nodemask=(null),cpuset=/,mems_allowed=0-1,task=panic,pid=8608,uid=0
>
> An admin can easily get the full oom context at a single line which
> makes parsing much easier.
>
> Signed-off-by: yuzhoujian <yuzhoujian@didichuxing.com>

Acked-by: Michal Hocko <mhocko@suse.com>

Btw. you can usually keep Acked-by for such a small change. If you are
not sure just ask off list.

> ---
> Changes since v13:
> - remove the spaces for printing pid and uid.
--
Michal Hocko
SUSE Labs

\
 
 \ /
  Last update: 2018-07-17 13:16    [W:0.069 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site