lkml.org 
[lkml]   [2018]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 30/32] staging: gasket: gasket_mmap use PAGE_MASK
On Mon, Jul 16, 2018 at 07:09:24PM -0700, Todd Poynor wrote:
> From: Todd Poynor <toddpoynor@google.com>
>
> Instead of math on PAGE_SIZE.
>

The commit message is sort of distinct from the first line. The first
line is like a title, not the start of a sentence. On like marc.info
when you're looking at patches, the Subject and the commit message are
sort of far apart so it looks weird. It looks weird on my email as
well.

Sorry, we're really hitting you with a bunch of nit-picky stuff. If you
were a one off contributer I'd just let a lot of this stuff slide but
since you're going to be a maintainer for a while then it's good to
learn all these micro rules at the begining.

regards,
dan carpenter

\
 
 \ /
  Last update: 2018-07-17 12:46    [W:0.325 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site