lkml.org 
[lkml]   [2018]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 12/32] staging: gasket: gasket_wait_with_reschedule return when condition hit
On Mon, Jul 16, 2018 at 07:09:06PM -0700, Todd Poynor wrote:
> From: Todd Poynor <toddpoynor@google.com>
>
> Return right away instead of break out of while and then return.
>

You could remove the (retries == max_retries) condition since that's
always true now and pull that code in one tab. You could do it in one
patch because they're closely related so it's One Thing [tm].

regads,
dan carpenter

\
 
 \ /
  Last update: 2018-07-17 12:14    [W:0.294 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site