Messages in this thread | | | Subject | Re: [PATCH] arm64: Clear the stack | From | Laura Abbott <> | Date | Tue, 17 Jul 2018 15:58:19 -0700 |
| |
On 07/03/2018 05:14 AM, Mark Rutland wrote: >> It might be cleaner just to use on_accessible_stack and then another >> function to get the top of stack. This also might just be >> reimplementing what x86 already has? (Mark, Ard?) > It looks like we could build a get_stack_info() as they have. > > We could probably clean up our stack traced atop of that, too.
So I spent some time looking at this and I'm not 100% clear if there would actually be much benefit to re-writing with get_stack_info. Most of that design seems to come from x86 needing to handle multiple unwind options which arm64 doesn't need to worry about. Any rework ended up with roughly the same code without any notable benefit that I could see. It's possible I'm missing what kind of cleanup you're suggesting but I think just going with a tweaked version of on_accessible_stack would be fine.
Thanks, Laura
| |